-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some converters #213
Conversation
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 97.92% 98.73% +0.80%
==========================================
Files 4 4
Lines 676 633 -43
==========================================
- Hits 662 625 -37
+ Misses 14 8 -6
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Can you increase the coverage by adding tests? |
will do on later PRs |
I think the type-piracy should be fixed, as it's quite egregious as it stands at the moment. |
This reverts commit 5ee8beb.
@putianyi889 I had to revert this commit as you are committing type-piracy. E.g.: # temporary patch. should be a PR(#48895) to LinearAlgebra
Diagonal{T}(A::AbstractMatrix) where T = Diagonal{T}(diag(A))
function convert(::Type{T}, A::AbstractMatrix) where T<:Diagonal
checksquare(A)
isdiag(A) ? T(A) : throw(InexactError(:convert, T, A))
end which does not relate to types in this package. Can you please fix these overloads and resubmit the PR? |
This is because Julia lowers some conversion to construction. A few constructors are added.