Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat entry for FillArrays #31

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

nickrobinson251
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files           4        4           
  Lines         153      153           
=======================================
  Hits          145      145           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85405f4...0395a2a. Read the comment docs.

@oxinabox
Copy link
Member

This is potentially problematic,
As if incompatible version of FillArrays is loaded Pkg's resolver will just downgrade BlockArrays to 1.3 which had no bounds.

This is I guess find to do,
but you likely want to also go into the registry and cap things retroactively

@nickrobinson251
Copy link
Contributor Author

This is potentially problematic,
As if incompatible version of FillArrays is loaded Pkg's resolver will just downgrade BlockArrays to 1.3 which had no bounds.

This is I guess find to do,
but you likely want to also go into the registry and cap things retroactively

🤷‍♂

@nickrobinson251 nickrobinson251 merged commit 891ae0d into master Oct 29, 2019
@nickrobinson251 nickrobinson251 deleted the npr/project-compat branch October 29, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants