Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extension depend on StaticArrays and optimize lu_instance #449

Merged

Conversation

oscardssmith
Copy link
Contributor

This will make the extension load less frequently (improving load times), and makes lu_instance about 20x faster by not making it actually do a lu factorization.

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.28%. Comparing base (193993c) to head (50e2776).
Report is 9 commits behind head on master.

Files Patch % Lines
ext/ArrayInterfaceStaticArraysExt.jl 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   70.17%   70.28%   +0.10%     
==========================================
  Files          10       11       +1     
  Lines         560      562       +2     
==========================================
+ Hits          393      395       +2     
  Misses        167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit afbc7bc into JuliaArrays:master Jul 28, 2024
18 checks passed
@oscardssmith oscardssmith deleted the os/refactor-StaticArray-ext branch July 28, 2024 03:22
oscardssmith added a commit to oscardssmith/ArrayInterface.jl that referenced this pull request Jul 30, 2024
ChrisRackauckas added a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants