Preserve the dimensions of ReverseDiff TrackedArray #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
avik-pal
commented
Mar 7, 2024
avik-pal
commented
- Fixes reversediff flattening arrays
- Removes old code
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 70.56% 71.16% +0.60%
==========================================
Files 7 8 +1
Lines 547 548 +1
==========================================
+ Hits 386 390 +4
+ Misses 161 158 -3 ☔ View full report in Codecov by Sentry. |
|
@ChrisRackauckas I am guessing the sign difference is coming from the diffeqcallbacks bug that you fixed and that hasn't been propagated to GaussAdjoint? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.