Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed can_setindex for MArray #429

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

jecs
Copy link
Contributor

@jecs jecs commented Feb 14, 2024

can_setindex now evaluates to true for Type{<:StaticArraysCore.MArray}.

See Issue 428.

@Tokazama

can_setindex now evaluates to true for Type{<:StaticArraysCore.MArray}
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc77c56) 70.51% compared to head (ae06bba) 70.56%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   70.51%   70.56%   +0.05%     
==========================================
  Files           7        7              
  Lines         546      547       +1     
==========================================
+ Hits          385      386       +1     
  Misses        161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tokazama
Copy link
Member

Just for the sake of completeness could you put a test in "/test/staticarrayscore.jl"? And then bump the patch version from 7.7.0 to 7.7.1 so we can release a fixed version.

@ChrisRackauckas ChrisRackauckas merged commit 7c5d183 into JuliaArrays:master Feb 15, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants