Index traits #410
Open
Index traits #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets a good chunk of the methods that can be made independent of Static.jl but
were in StaticArrayInterface.jl.
- is_splat_index
- known_length: the followning are necessary to get known_length to work
- known_size
- known_first
- known_last
- known_step
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
===========================================
- Coverage 76.55% 23.48% -53.07%
===========================================
Files 7 10 +3
Lines 563 694 +131
===========================================
- Hits 431 163 -268
- Misses 132 531 +399
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I'm not looking at any new things until a round of bug fixes for like a week or two. |
Feel free to ping me if any are applicable to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets a good chunk of the methods that can be made independent of Static.jl but
were in StaticArrayInterface.jl.