Fix @assume_effects compat
#361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia v1.6 doesn't have assumed effects so we have a fallback defined. However, the previous implementation doesn't have proper macro hygeine and assumes only `@assume_effects :total call` is every done. This only provides the `@pure` def when applicable.
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 9 9
Lines 1337 1337
=======================================
Hits 1207 1207
Misses 130 130 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chriselrod
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia v1.6 doesn't have assumed effects so we have a fallback defined. However, the previous implementation doesn't have proper macro hygiene and assumes only
@assume_effects :total callis ever done. This only provides the@puredef when applicable.