Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ioannisPApapadopoulos @dlfivefifty
I have started the process replacing Lancos with Cholesky. There are some workarounds present in the current version which can be removed once these two issues are resolved:
JuliaLinearAlgebra/InfiniteLinearAlgebra.jl#124
JuliaLinearAlgebra/InfiniteLinearAlgebra.jl#123
The package currently requires ClassicalOrthogonalPolynomials.jl from my branch here. That branch has an adhoc workaround for the isposdef try/catch bug mentioned above so it is prone to break until we fix that.
Furthermore, I currently have to make use of and include SelectInfiniteBand in this repo, which I described here. I expect that this functionality will end up being moved into e.g. InfiniteLinearAlgebra.jl or something to that effect. For now I keep it here so I can test the functionality.No longer needed due to simpler but still temporary workaround mentioned here.Please bear with me as what I am trying to do here is basically ripping out the spine of this package and replacing it with a new one -- there will be a lot of bugs to fix; I am happy to get bug reports!
All these caveats aside, here is a demo of something that already works which might be relevant for @ioannisPApapadopoulos :
(PS: I haven't yet done any sanity testing on whether the above is a reasonably accurate, too much still to do before I get to that. In low weight params where I can test easily it all seems correct.)