-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using EltypeExtensions: elconvert #105
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 64.25% 64.21% -0.04%
==========================================
Files 23 23
Lines 1835 1836 +1
==========================================
Hits 1179 1179
- Misses 656 657 +1 ☔ View full report in Codecov by Sentry. |
the drop in coverage is expected due to #113 |
This could just be an extension in EltypeExtensions.jl |
It wouldn't work since EltypeExtensions is low-level. Making it a dependent will cause dependency loop error. |
That's not true. If it's an extension it's only loaded when the downstream package is loaded so there is no circular dependency. |
But I accept your point that it would be weird |
When I tried adding extensions I did get errors. I think it's because Project.toml needs to have compatible versions, and the version-dependencies form loops which Julia can't resolve. |
related: