Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using EltypeExtensions: elconvert #105

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

putianyi889
Copy link
Contributor

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.21%. Comparing base (b0741da) to head (9ec8020).

Files with missing lines Patch % Lines
src/quasibroadcast.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   64.25%   64.21%   -0.04%     
==========================================
  Files          23       23              
  Lines        1835     1836       +1     
==========================================
  Hits         1179     1179              
- Misses        656      657       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@putianyi889 putianyi889 mentioned this pull request Nov 1, 2024
4 tasks
@putianyi889
Copy link
Contributor Author

the drop in coverage is expected due to #113

@dlfivefifty
Copy link
Member

This could just be an extension in EltypeExtensions.jl

@putianyi889
Copy link
Contributor Author

This could just be an extension in EltypeExtensions.jl

It wouldn't work since EltypeExtensions is low-level. Making it a dependent will cause dependency loop error.

@dlfivefifty
Copy link
Member

That's not true. If it's an extension it's only loaded when the downstream package is loaded so there is no circular dependency.

@dlfivefifty
Copy link
Member

But I accept your point that it would be weird

@putianyi889
Copy link
Contributor Author

putianyi889 commented Dec 20, 2024

That's not true. If it's an extension it's only loaded when the downstream package is loaded so there is no circular dependency.

When I tried adding extensions I did get errors. I think it's because Project.toml needs to have compatible versions, and the version-dependencies form loops which Julia can't resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants