Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to float in transform/itransform #627

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 31, 2024

With this, the following works:

julia> transform(Chebyshev(), 1:2)
2-element Vector{Float64}:
  1.5
 -0.7071067811865476

Fix JuliaApproximation/ApproxFun.jl#659

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (768625d) 75.07% compared to head (272ead2) 70.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   75.07%   70.50%   -4.58%     
==========================================
  Files          80       80              
  Lines        8439     8405      -34     
==========================================
- Hits         6336     5926     -410     
- Misses       2103     2479     +376     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jishnub added a commit to jishnub/ApproxFunBase.jl that referenced this pull request Jan 31, 2024
@jishnub jishnub merged commit 13ebdba into JuliaApproximation:master Jan 31, 2024
13 of 14 checks passed
@jishnub jishnub deleted the transformfloat branch January 31, 2024 09:31
jishnub added a commit that referenced this pull request Jan 31, 2024
* Backport: Use mutable copies in transform/itransform

* Backport: Convert to float in transform/itransform #627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting Fun errors when Fun is generated from a vector of integers
1 participant