-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement calculus operations for ConstantSpace #595
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 74.36% 74.68% +0.31%
==========================================
Files 80 80
Lines 8418 8421 +3
==========================================
+ Hits 6260 6289 +29
+ Misses 2158 2132 -26
☔ View full report in Codecov by Sentry. |
I think the test for the integral needs to be added to |
This reverts commit 0a1269a.
Got it, thanks for the review! Should I create a PR for ApproxFunOrthogonalPolynomials? |
Sure, but that test PR would need this to be merged first. Maybe you can bump the patch version of this package to 0.9.15 in this PR, and set the minimum compat bound for |
Thanks! |
I have implemented the
integrate
anddifferentiate
methods forConstantSpace
. This addition was motivated to add support for taking the norm of ConstantSpace functionals. I have also added a test for the norm operation.