-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make new Rotation constructor and redefine anim_rotate[_around] #454
Make new Rotation constructor and redefine anim_rotate[_around] #454
Conversation
to handle Integer and Irrational rotation angles.
Hey @leephillips ! Thank you for making this PR and working with @Wikunia on this! Also, we try to always recognize all contributors to Javis! Thanks @leephillips ! |
of anim_rotate_around() and anim_rotate().
”the docstrings for these functions may need to be updated to reflect the new type signatures.” Quite right. I updated the docstrings in a new commit. |
Thanks @leephillips |
Looks good to me. |
Test cases should pass after #455 is merged. 😉 |
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 36 36
Lines 1633 1634 +1
=======================================
+ Hits 1572 1573 +1
Misses 61 61
Continue to review full report at Codecov.
|
to handle Integer and Irrational rotation angles.
PR Checklist
If you are contributing to
Javis.jl
, please make sure you are able to check off each item on this list:CHANGELOG.md
with whatever changes/features I added with this PR?Project.toml
+ set an upper bound of the dependency (if applicable)?test
directory (if applicable)?Link to relevant issue(s)
Closes #450
How did you address these issues with this PR? What methods did you use?
Added a constructor for Rotation that promotes arguments to have the same type;
changed type signatures of anim_rotate_around() and anim_rotate().