Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new Rotation constructor and redefine anim_rotate[_around] #454

Merged
merged 4 commits into from
Dec 31, 2021

Conversation

leephillips
Copy link
Contributor

to handle Integer and Irrational rotation angles.

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #450

How did you address these issues with this PR? What methods did you use?

Added a constructor for Rotation that promotes arguments to have the same type;
changed type signatures of anim_rotate_around() and anim_rotate().

to handle Integer and Irrational rotation angles.
@TheCedarPrince
Copy link
Member

Hey @leephillips !

Thank you for making this PR and working with @Wikunia on this!
I will let @Wikunia do a review of this more thoroughly as you have been working with him the most on this PR but one thing I notice is that the docstrings for these functions may need to be updated to reflect the new type signatures.

Also, we try to always recognize all contributors to Javis!
We will be sure to add your name to the list of our contributors in our README before we finish this PR.
You can also do that if you are willing but otherwise, we will take care of it for you.

Thanks @leephillips !

of anim_rotate_around() and anim_rotate().
@leephillips
Copy link
Contributor Author

”the docstrings for these functions may need to be updated to reflect the new type signatures.”

Quite right. I updated the docstrings in a new commit.

@Wikunia Wikunia self-requested a review December 31, 2021 18:05
@Wikunia
Copy link
Member

Wikunia commented Dec 31, 2021

Thanks @leephillips
I've added a line to the changelog and changed your test cases a little bit.

@leephillips
Copy link
Contributor Author

Looks good to me.

@Wikunia
Copy link
Member

Wikunia commented Dec 31, 2021

Test cases should pass after #455 is merged. 😉

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #454 (ea51d39) into master (5731259) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files          36       36           
  Lines        1633     1634    +1     
=======================================
+ Hits         1572     1573    +1     
  Misses         61       61           
Impacted Files Coverage Δ
src/structs/Transitions.jl 94.44% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5731259...ea51d39. Read the comment docs.

@Wikunia Wikunia merged commit 0ec51d5 into JuliaAnimators:master Dec 31, 2021
@leephillips leephillips deleted the leephillips-issue-450 branch December 31, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Irrational and Integer angles fail in rotation Actions
4 participants