Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return nothing if pathname is empty and empty the constants #442

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

Wikunia
Copy link
Member

@Wikunia Wikunia commented Nov 7, 2021

PR Checklist

The CURRENT constants should always be reset even if the liveviewer is used without a pathname.
This fixes one point mentioned by @gpucce in #434

How did you address these issues with this PR? What methods did you use?
I return nothing in that case and call empty_CURRENT_constants

@Wikunia Wikunia requested a review from gpucce November 7, 2021 10:07
@Wikunia
Copy link
Member Author

Wikunia commented Nov 7, 2021

Hmm I see. I think it's more a testing bug though but will have a look later. I think we shouldn't call render and assume to have access to the stuff later on. That is kind of what emptying the constants should make sure in the first place.

@gpucce
Copy link
Member

gpucce commented Nov 7, 2021

Hmm I see. I think it's more a testing bug though but will have a look later. I think we shouldn't call render and assume to have access to the stuff later on. That is kind of what emptying the constants should make sure in the first place.

yeah I think I get it, it happens because in the testing there are calls to functions involving vid after it has already been rendered right?

@Wikunia
Copy link
Member Author

Wikunia commented Nov 7, 2021

We should also empty those when we call the liveviewer which is done at the top of the render function.

@gpucce gpucce self-requested a review November 7, 2021 11:03
gpucce
gpucce previously approved these changes Nov 7, 2021
Copy link
Member

@gpucce gpucce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not mean to ask my own review

@Wikunia
Copy link
Member Author

Wikunia commented Nov 7, 2021

Haha you approved it three times now and it is still buggy 😄

@gpucce
Copy link
Member

gpucce commented Nov 7, 2021

Haha you approved it three times now and it is still buggy 😄

I don't know how this works, I wanted to make it un-approved but apperently that is not how it works? (sorry for the mess)

@Wikunia Wikunia requested a review from gpucce November 7, 2021 11:10
@Wikunia Wikunia dismissed gpucce’s stale review November 7, 2021 11:11

Premature :D

@Wikunia
Copy link
Member Author

Wikunia commented Nov 7, 2021

@TheCedarPrince I'm not super sure how the liveviewer works. Is there any possibility to clear the constants after the gtk window was closed?

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #442 (8425e90) into master (0ec51d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   96.26%   96.27%           
=======================================
  Files          36       36           
  Lines        1634     1636    +2     
=======================================
+ Hits         1573     1575    +2     
  Misses         61       61           
Impacted Files Coverage Δ
src/Javis.jl 96.08% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec51d5...8425e90. Read the comment docs.

@Wikunia Wikunia changed the base branch from master to main February 25, 2022 18:35
@Wikunia Wikunia merged commit 435745e into main Apr 21, 2022
@Wikunia Wikunia deleted the bugfix-empty_CURRENT_constants branch April 21, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants