-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return nothing if pathname is empty and empty the constants #442
Conversation
Hmm I see. I think it's more a testing bug though but will have a look later. I think we shouldn't call |
yeah I think I get it, it happens because in the testing there are calls to functions involving |
We should also empty those when we call the liveviewer which is done at the top of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not mean to ask my own review
Haha you approved it three times now and it is still buggy 😄 |
I don't know how this works, I wanted to make it un-approved but apperently that is not how it works? (sorry for the mess) |
@TheCedarPrince I'm not super sure how the liveviewer works. Is there any possibility to clear the constants after the gtk window was closed? |
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
=======================================
Coverage 96.26% 96.27%
=======================================
Files 36 36
Lines 1634 1636 +2
=======================================
+ Hits 1573 1575 +2
Misses 61 61
Continue to review full report at Codecov.
|
PR Checklist
The
CURRENT
constants should always be reset even if the liveviewer is used without a pathname.This fixes one point mentioned by @gpucce in #434
How did you address these issues with this PR? What methods did you use?
I return
nothing
in that case and callempty_CURRENT_constants