Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postprocessing frame check bug fix #431

Merged
merged 36 commits into from
Oct 5, 2021

Conversation

gpucce
Copy link
Member

@gpucce gpucce commented Oct 2, 2021

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #

How did you address these issues with this PR? What methods did you use?
The check for frames returned by postprocess_frames_flow was wrongly written, this should fix it.

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #431 (2695819) into master (5781699) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2695819 differs from pull request most recent head e9bd758. Consider uploading reports for the commit e9bd758 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files          36       36           
  Lines        1604     1604           
=======================================
  Hits         1543     1543           
  Misses         61       61           
Impacted Files Coverage Δ
src/Javis.jl 96.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5781699...e9bd758. Read the comment docs.

@Wikunia
Copy link
Member

Wikunia commented Oct 3, 2021

I don't know how the previous code could result in a failure. Probably missing something here. Aren't the frames always from 1-... ? Isn't gif rendering would fail otherwise? Maybe add a test which would fail in the current version and is fixed by this.

Btw make sure to update your personal fork before creating a PR. (For the next one don't worry about this one) as currently this PR has >30 commits but only the last is the one which isn't merged already

@gpucce
Copy link
Member Author

gpucce commented Oct 3, 2021

Sorry for merging I though I did.

The error was this, I think for javis is not an issue having for example frame 0 defined but with the old solution this would throw this error instead of using frame 0 normally, now it shouldn't anymore.

I think it throws a warning but does not fail with frame 0 at least. Anyway even if it would fail anyway it is still better to have the regular error instead of this one that would be unexplicative.

I will check again and add the test later today!

@gpucce
Copy link
Member Author

gpucce commented Oct 5, 2021

So I adapted a test in postprocessing to account for the negative frames and it does work with this PR while it does not without it.

@Wikunia
Copy link
Member

Wikunia commented Oct 5, 2021

Great thanks

Copy link
Member

@Wikunia Wikunia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM. Please add a line to the changelog :)
Then I'll merge and tag a new release

@gpucce
Copy link
Member Author

gpucce commented Oct 5, 2021

That should be it!

@Wikunia Wikunia merged commit 86a3655 into JuliaAnimators:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants