suggested fixes, shorthands and for cycle. #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Created outline for layers tutorial * Building blocks of layers_tutorial I added the gifs and most of the code blocks to the tutorial though some of the gifs still need tweaking. * remove duplicate code * remove duplicate code * remove duplicate code * Rename layers_tutorial to tutorial_8 add link to tutorial 8 in beginners start here page add tutorial_8 to make.jl * update gifs * remove older version * remove typos and misc-todo list * more typos * more typos and similar * more typos and similar * more typos and similar * more typos and similar * fix error in code snippet * Updates to Tutorial 8 to add clarity and formatting * Added first draft of layers * Fixed grammar Co-authored-by: gpucce <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 35 35
Lines 1521 1521
=======================================
Hits 1464 1464
Misses 57 57 Continue to review full report at Codecov.
|
|
LGTM I'll let @TheCedarPrince merge this as he reviewed the original one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you are contributing to
Javis.jl, please make sure you are able to check off each item on this list:CHANGELOG.mdwith whatever changes/features I added with this PR?Project.toml+ set an upper bound of the dependency (if applicable)?testdirectory (if applicable)?Link to relevant issue(s)
Closes #415 hopefully
How did you address these issues with this PR? What methods did you use?
I added the changes plus a typo (assuming I get the english right :)) and I used the formatter it basically only changes the Animation definition if you liked it better before I switch it back.