Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for get_position on Layer #401

Merged

Conversation

EnzioKam
Copy link
Contributor

@EnzioKam EnzioKam commented Aug 15, 2021

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)

How did you address these issues with this PR? What methods did you use?
The type annotation in documentation for get_position on Layers here is a duplicate of the one for Object here.

This PR just changes 1 line to show the correct type annotation in the documentation.

@codecov
Copy link

codecov bot commented Aug 15, 2021

Codecov Report

Merging #401 (d484a19) into master (05a87b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files          35       35           
  Lines        1521     1521           
=======================================
  Hits         1464     1464           
  Misses         57       57           
Impacted Files Coverage Δ
src/layers.jl 84.37% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a87b9...d484a19. Read the comment docs.

@Wikunia
Copy link
Member

Wikunia commented Aug 15, 2021

Thanks

@Wikunia Wikunia merged commit 2f9e047 into JuliaAnimators:master Aug 15, 2021
@EnzioKam EnzioKam deleted the EnzioKam-documentation-getposition branch August 15, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants