Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Galton Board example #397

Merged

Conversation

EnzioKam
Copy link
Contributor

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)

How did you address these issues with this PR? What methods did you use?
Adds the Galton Board example to the Examples page in the documentation.

@EnzioKam EnzioKam changed the title Enzio kam documentation example galton Add Galton Board example Aug 14, 2021
Copy link
Member

@TheCedarPrince TheCedarPrince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EnzioKam - thanks for the great PR! I think we are set to merge. I'll ping @Wikunia for a quick review but otherwise, this looks fantastic! The code is quite interesting - much smaller than I anticipated frankly and your documentation is stellar.

Ole, feel free to merge if it looks good to you!

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #397 (8155795) into master (4c17cc7) will not change coverage.
The diff coverage is n/a.

❗ Current head 8155795 differs from pull request most recent head 7279e56. Consider uploading reports for the commit 7279e56 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files          35       35           
  Lines        1521     1521           
=======================================
  Hits         1464     1464           
  Misses         57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c17cc7...7279e56. Read the comment docs.

Copy link
Member

@Wikunia Wikunia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things. Thanks for the update

examples/galton.jl Outdated Show resolved Hide resolved
examples/galton.jl Outdated Show resolved Hide resolved
examples/galton.jl Outdated Show resolved Hide resolved
@EnzioKam EnzioKam requested a review from Wikunia August 14, 2021 09:47
@Wikunia Wikunia merged commit 05a87b9 into JuliaAnimators:master Aug 14, 2021
@Wikunia
Copy link
Member

Wikunia commented Aug 14, 2021

Thank you 🎉

@EnzioKam EnzioKam deleted the EnzioKam-documentation-example-galton branch August 15, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants