Add "Escaping from the Swirling Vortex" example #389
Conversation
|
Thanks a lot @rmsrosa |
There was a problem hiding this comment.
That looks awesome. I mean I don't have a clue about most of it but it looks beautiful 😄
Might need to check out the paper 🤔
Thanks for the code and so many comments.
Do you mind running
using JuliaFormatter
format("examples/")
from the root directory as it seems like some indentations are a bit off
| end | ||
|
|
||
| function ode_arrow(x, y, t, frm_scl, arrow_color) | ||
| ode_arrow(x, y, t, frm_scl, [arrow_color, arrow_color]) |
There was a problem hiding this comment.
I think the [, ] shouldn't be there
There was a problem hiding this comment.
Oh, that is right. That is reminiscent of a failed attempt to add a blue arrow for the trajectory itself. I better just remove this dispatch for this example since it is not used.
As for the JuliaFormatter.jl, I was hoping to get away without it, but I guess I was caught 😆 . I never used that and I understood I need to install in my global env, right? I will give it a try.
There was a problem hiding this comment.
No worries about the formatter. I can also run this 😉
Yes make sure to update the docstring as well then for the ode_arrow function
There was a problem hiding this comment.
Ok, I just run JuliaFormatter.jl. It was actually a good thing to do. Thanks!
There was a problem hiding this comment.
Great. You only ran it on the examples, right? Maybe try running it on all with format(".") as we have some weirdness in src/latex... which I can't replicate on my machine 😄
|
Hmm, how come the Oh, it is complaining about |
|
Yeah formatting is a bit weird sometimes especially with that file. It says it's fine on my machine but the CI doesn't like it. Wondering what your machine says 😄 |
|
Ok, |
|
Yeah unfortunately it doesn't seem like one can ignore files... Anyhow that's not your problem 😄 We'll figure something out. |
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
=======================================
Coverage 96.24% 96.24%
=======================================
Files 35 35
Lines 1519 1519
=======================================
Hits 1462 1462
Misses 57 57 Continue to review full report at Codecov.
|
|
I'd say we could probably go ahead and merge this as is. Those particular latex files always give us issues anyhow. :/ |
|
format is fixed in master now. |
|
I think this deserves an entry in the Summer of Math Exposition. Also it would be good place to show off Javis. |
Haven't changed any Core or Test code. Just adding an example. 😃