Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change can now also set value #295

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Conversation

Wikunia
Copy link
Member

@Wikunia Wikunia commented Nov 26, 2020

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #279

How did you address these issues with this PR? What methods did you use?
I've added a change method which accepts everything but pairs and just set the keyword specified to that value. I additionally found a bug that appeared with ; keep=false as this didn't work for change. It now resets the dictionary every time such that it works now.

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #295 (ef063bb) into master (e393802) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   95.92%   95.93%   +0.01%     
==========================================
  Files          21       21              
  Lines        1005     1008       +3     
==========================================
+ Hits          964      967       +3     
  Misses         41       41              
Impacted Files Coverage Δ
src/Javis.jl 97.39% <100.00%> (+0.02%) ⬆️
src/action_animations.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e393802...ef063bb. Read the comment docs.

Copy link
Member

@TheCedarPrince TheCedarPrince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@Wikunia Wikunia merged commit 2e5d1f6 into master Dec 2, 2020
@Wikunia Wikunia deleted the wik-feature-change-set-value branch December 2, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a set function similar to change which just sets the value
2 participants