Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial 1 v0.3 #244

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Tutorial 1 v0.3 #244

merged 3 commits into from
Oct 22, 2020

Conversation

Wikunia
Copy link
Member

@Wikunia Wikunia commented Oct 21, 2020

PR Checklist

Needs #230 to work

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

@Wikunia Wikunia mentioned this pull request Oct 21, 2020
7 tasks
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #244 into v0.3 will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.3     #244      +/-   ##
==========================================
+ Coverage   96.91%   97.35%   +0.43%     
==========================================
  Files          19       19              
  Lines         712      717       +5     
==========================================
+ Hits          690      698       +8     
+ Misses         22       19       -3     
Impacted Files Coverage Δ
src/structs/Video.jl 100.00% <0.00%> (ø)
src/structs/Object.jl 100.00% <0.00%> (ø)
src/structs/Transitions.jl 100.00% <0.00%> (ø)
src/object_values.jl
src/symbol_values.jl 95.23% <0.00%> (ø)
src/Javis.jl 98.29% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7b8a7...6d97882. Read the comment docs.

@TheCedarPrince TheCedarPrince merged commit 473b9b6 into v0.3 Oct 22, 2020
@TheCedarPrince TheCedarPrince deleted the wik-tutorial-1-v0.3 branch October 22, 2020 15:55
TheCedarPrince added a commit that referenced this pull request Nov 10, 2020
* first step of Action -> Object, SubAction -> Action (#226)

* first step of Action -> Object, SubAction -> Action
* docstring for Action
* docstrings for Object

* Implementation of render and act  (#228)

* use act and render syntax

* Working with the variable instead of the id (#230)

* working without extra identifier

* Tutorial 1 v0.3 (#244)

* tutorial 1 for v0.3

* Updated tutorial 1 explanation

Co-authored-by: Jacob Zelko <[email protected]>

* Docstrings v0.3 (#237)

* first step of Action -> Object, SubAction -> Action

* fixed unit tests

* fixed svg tests

* fix animations.jl (only morphing is missing)

* changed morphing. All tests should pass

* codecov and ambiguity

* docstring for Action

* small docstring fixes

* removed ability to have more transitions in one action

* docstrings for Object

* docstring for BackgroundObject

* copy action when adding to an object

* use act and render syntax

* working without extra identifier

* extra codecov test

* updated tutorial 1

* some docstring fixes for v0.3

* Final check on first pass of v0.3.0 docstrings

Co-authored-by: Jacob Zelko <[email protected]>

* Ability to disable an action after its last defined frame (#242)

* keep or not keep an action

* Wik feature setopacity (#241)

* implementation of setopacity

* Translation -> anim_translate and co + unit tests (#250)

* Translation -> anim_translate and co + unit tests

* Change BackgroundObject to Background (#261)

* sed and replaced all occurences of BackgroundObject to Background

* Notice about syntax change for background

* Added notice about change of Action syntax

* Formatted docstring for Background

* Tutorial 1 for v0.3 (#262)

* updated tutorial to `anim_rotate_around`
Co-authored-by: Jacob Zelko <[email protected]>

* Feature global frames (#265)

* bugfix in :same for Action and implementation of Glob
* Rel -> RFrames,  Glob to GFrames

* Example follow path v0.3 (#264)

* follow bezier path for v0.3 with GFrames

* preprocess_frames! function (#263)

* preprocess_frames! function
Co-authored-by: Jacob Zelko <[email protected]>

* Tutorial 6 for v0.3 (#267)

* tutorial 6 for v0.3
* Adjusted some grammar and light rewording of some sentences
Co-authored-by: Jacob Zelko <[email protected]>

* HowTo v0.3 (#269)

* first part of HowTo
Co-authored-by: Jacob Zelko <[email protected]>

* Updated Jarvis (#272)

* Updated Jarvis with draw_text
Co-authored-by: Jacob Zelko <[email protected]>

* LaTeX tutorial for v0.3 (#271)

* updated Latex tutorial
Co-authored-by: Jacob Zelko <[email protected]>

* [WIP] Feature transpose (#175)

- morphing several shapes 
   - i.e. transpose
Co-authored-by: Jacob Zelko <[email protected]>

* Warning if no background (#273)

* show a warning if some frames don't have a background

* Update Tutorial 2 for v0.3.0 (#268)

* Reduxed code for tutorial 2

* Changed notes from Action to Object syntax

* Cleaned code and fixed up grammar

* Fixed wording

* Fixed code

* Fixed references to Object

* Removed superfluous file

* Removed section on Animation

* v0.3 Fourier (#274)

* fourier example

* Docstrings for v0.3 (#276)

* docstrings fixes for anim_, act!, javis, SubAction, grammar
Co-authored-by: Jacob Zelko <[email protected]>

* Warning if action is defined out of object frames (#278)

* Throw warning if action is outside object frames

* test case fix + format

* Clarified warning msg

Co-authored-by: Jacob Zelko <[email protected]>

* Redux of tutorial 5 (#280)

* Redux of tutorial 5
Co-authored-by: Ole Kröger <[email protected]>

* Final check v0.3 (#281)

* Removed SubAction and checked for Rel/BackgroundAction
* fixed all references
* added line to changelog
* finished v0.3
Co-authored-by: Ole Kröger <[email protected]>

* format

* Taming and link to change

* changed SubAction name to Action

* removed prints

Co-authored-by: Jacob Zelko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants