CompatHelper: bump compat for ScientificTypesBase to 3, (keep existing compat) #15
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## dev #15 +/- ##
=======================================
Coverage 88.33% 88.33%
=======================================
Files 7 7
Lines 180 180
=======================================
Hits 159 159
Misses 21 21
Continue to review full report at Codecov.
|
|
I suspect that, for testing purposes, this PR needs:
|
|
Ok cool - should we just hold off until that is released? |
|
I don't understand this fail, which seems to be something new about testing under 1.7, as 1.3 tests pass. In particular, I don't understand " ├─restricted to versions 2.2.2-2 by MLJText [5e27fcf9], leaving only versions 2.2.2-2.3.3" because this PR is extending the compat for ScientificTypesBase to include 3^. Perhaps @DilumAluthge can explain?
|
|
You'll need to update the compat entry for ScientificTypes to allow ScientificTypes v3. |
|
Just FYI, the CI failure on 1.7 is a good thing. It tells us that the fix in JuliaRegistries/CompatHelper.jl#298 is working correctly. |
|
@DilumAluthge Thanks for your help here! |
This pull request changes the compat entry for the
ScientificTypesBasepackage from2.2.0to2.2.0, 3.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.