Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor doc improvements #137

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Some minor doc improvements #137

merged 1 commit into from
Jan 20, 2023

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jan 20, 2023

No description provided.

@ablaom ablaom requested a review from jbrea January 20, 2023 03:15
@codecov-commenter
Copy link

Codecov Report

Merging #137 (9b1c2d0) into dev (a41ee42) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #137   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files          20       20           
  Lines         875      875           
=======================================
  Hits          828      828           
  Misses         47       47           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

where:

- `L` is a loss function
- `X` is the `n` x `p` matrix of training observations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might even add here that n is the number of observations and p the number of features, it's a standard convention but can trip people up

@tlienart
Copy link
Collaborator

this is great, I'll do the small n/p change myself

@tlienart tlienart merged commit 7140a33 into dev Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants