Hard deps and CSV->DelimitedFiles #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2019
ablaom
reviewed
Nov 5, 2019
ablaom
reviewed
Nov 5, 2019
ablaom
requested changes
Nov 5, 2019
|
ok done, actually I'm glad you spotted it because the code for the datasets wasn't properly included 🙄 should be all good now |
|
It looks like the macro forms of loading data still import CSV: macro load_boston()
quote
import CSV
y, X = unpack(load_boston(), ==(:MedV), x->x != :Chas)
(X, y)
end
end(As a side note: the raison d'etre for using macros - importing an optional dependency - is gone. Let's keep the macro - which has a different return value from the functions - because otherwise we break MLJ) |
|
thanks yes will remove those |
ablaom
approved these changes
Nov 5, 2019
ablaom
reviewed
Nov 6, 2019
| load_iris() = load_dataset("iris.csv", COERCE_IRIS) | ||
| load_crabs() = load_dataset("crabs.csv", COERCE_CRABS) | ||
|
|
||
| load_crabs() | ||
|
|
There was a problem hiding this comment.
I'm not sure this fixes the travis fail, but line 166 is presumably not supposed to be here.
ablaom
reviewed
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
DelimitedFilesto loadboston, etcSee also JuliaAI/ScientificTypes.jl#38; this addresses #77 ; ideally merge this in dev second (after merging JuliaAI/ScientificTypes.jl#38)