Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement some numbers to prepare to control charging current #55

Closed
wants to merge 2 commits into from

Conversation

ivanfmartinez
Copy link
Contributor

Add some fields identified on #52 as number to be able to control charging parameters.

Before implementing the real control the proxy must be able to respond to the juicebox without enel x servers responding as #54 .

@snicker snicker requested review from snicker and Snuffy2 April 2, 2024 04:09
@snicker snicker self-assigned this Apr 2, 2024
@snicker snicker marked this pull request as draft April 2, 2024 04:10
@snicker
Copy link
Collaborator

snicker commented Apr 2, 2024

changing to draft while research continues in #39

@Snuffy2
Copy link
Collaborator

Snuffy2 commented Apr 28, 2024

@ivanfmartinez I'm going to incorporate some of these changes into #58. As it is a large behind the scenes rewrite, it will likely be easier to put this code in the right new places as opposed to having you sort out the new places to put it later.

I'll clarify the full list here and in #58 of what I incorporated.

@Snuffy2 Snuffy2 mentioned this pull request Apr 29, 2024
@ivanfmartinez
Copy link
Contributor Author

@ivanfmartinez I'm going to incorporate some of these changes into #58. As it is a large behind the scenes rewrite, it will likely be easier to put this code in the right new places as opposed to having you sort out the new places to put it later.

I'll clarify the full list here and in #58 of what I incorporated.

@Snuffy2 this callbacks are to be able to send new configuration values do the juicebox faster without waiting for a new message came from juicebox. But if you find another way to do this there is no problem.

@Snuffy2
Copy link
Collaborator

Snuffy2 commented Jun 7, 2024

@ivanfmartinez ok if we close this PR?

@ivanfmartinez
Copy link
Contributor Author

Now on #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants