Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflow to Create GitHub Container Docker #10

Conversation

Snuffy2
Copy link
Collaborator

@Snuffy2 Snuffy2 commented Nov 9, 2023

  • It will create multi-arch images for: linux/amd64, linux/arm64, linux/arm/v7
  • For any release, it will create images with the <version number> and latest tags
    • The release tag must be valid semver
    • For pre-releases, it will create the <version number> tag but not latest
  • For any push and pull-request merge to the master (or main) branch, it will create images with the edge tag
  • It will only run for @snicker and not for forks of the repo
  • Dependabot should auto-create PRs to update the workflow versions (if enabled in the Repo settings).

@snicker if you want to use this, please merge it and then make a first release (maybe v0.1.0). I can then test to ensure it works and will then make another PR to update the Readme with revised Docker Compose instructions.

The docker image location should be: ghcr.io/snicker/juicepassproxy

@devzwf
Copy link

devzwf commented Nov 9, 2023

i would recommend :
FROM python:3.12-slim-bookworm
Or the image will be huge.

@Snuffy2 Snuffy2 force-pushed the GitHub-Action-to-Create-GitHub-Container-Docker branch from fda5275 to f26c378 Compare November 9, 2023 22:13
@Snuffy2
Copy link
Collaborator Author

Snuffy2 commented Nov 9, 2023

Makes sense. Changed.

@snicker
Copy link
Collaborator

snicker commented Nov 11, 2023

@Snuffy2 tracking in #11 - thanks a bunch for setting this up

@Snuffy2 Snuffy2 deleted the GitHub-Action-to-Create-GitHub-Container-Docker branch November 11, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants