add jsonkeyindex unitest

Signed-off-by: Xianhui.Lin <[email protected]>
JsDove · Jan 20, 2025 · b4e690a · b4e690a
1 parent 36ac66b
commit b4e690a
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 23 deletions.
diff --git a/internal/core/src/exec/expression/UnaryExpr.cpp b/internal/core/src/exec/expression/UnaryExpr.cpp
@@ -964,8 +964,13 @@ PhyUnaryRangeFilterExpr::ExecRangeVisitorImplJsonForIndex() {
                         }
                         return !CompareTwoJsonArray(array.value(), val);
                     } else {
-                        UnaryRangeJSONIndexCompareNotEqual(
-                            ExprValueType(x.value()) != val);
+                        if (!arrayIndex.empty()) {
+                            UnaryRangeJSONIndexCompareWithArrayIndex(
+                                ExprValueType(x.value()) != val);
+                        } else {
+                            UnaryRangeJSONIndexCompareNotEqual(
+                                ExprValueType(x.value()) != val);
+                        }
                     }
                 case proto::plan::PrefixMatch:
                     if constexpr (std::is_same_v<GetType, proto::plan::Array>) {

diff --git a/internal/core/unittest/test_expr.cpp b/internal/core/unittest/test_expr.cpp
@@ -1230,16 +1230,17 @@ TEST_P(ExprTest, TestUnaryRangeJson) {
         int64_t val;
         std::vector<std::string> nested_path;
     };
-    std::vector<Testcase> testcases{
-        {10, {"int"}},
-        {20, {"int"}},
-        {30, {"int"}},
-        {40, {"int"}},
-        {10, {"double"}},
-        {20, {"double"}},
-        {30, {"double"}},
-        {40, {"double"}},
-    };
+    std::vector<Testcase> testcases{{10, {"int"}},
+                                    {20, {"int"}},
+                                    {30, {"int"}},
+                                    {40, {"int"}},
+                                    {10, {"double"}},
+                                    {20, {"double"}},
+                                    {30, {"double"}},
+                                    {40, {"double"}},
+                                    {1, {"array", "0"}},
+                                    {2, {"array", "1"}},
+                                    {3, {"array", "2"}}};
 
     auto schema = std::make_shared<Schema>();
     auto i64_fid = schema->AddDebugField("id", DataType::INT64);
@@ -1341,11 +1342,13 @@ TEST_P(ExprTest, TestUnaryRangeJson) {
 
             for (int i = 0; i < N * num_iters; ++i) {
                 auto ans = final[i];
-                if (testcase.nested_path[0] == "int") {
+                if (testcase.nested_path[0] == "int" ||
+                    testcase.nested_path[0] == "array") {
                     auto val =
                         milvus::Json(simdjson::padded_string(json_col[i]))
                             .template at<int64_t>(pointer)
                             .value();
+
                     auto ref = f(val);
                     ASSERT_EQ(ans, ref);
                     if (i % 2 == 0) {
@@ -1442,16 +1445,17 @@ TEST_P(ExprTest, TestUnaryRangeJsonNullable) {
         int64_t val;
         std::vector<std::string> nested_path;
     };
-    std::vector<Testcase> testcases{
-        {10, {"int"}},
-        {20, {"int"}},
-        {30, {"int"}},
-        {40, {"int"}},
-        {10, {"double"}},
-        {20, {"double"}},
-        {30, {"double"}},
-        {40, {"double"}},
-    };
+    std::vector<Testcase> testcases{{10, {"int"}},
+                                    {20, {"int"}},
+                                    {30, {"int"}},
+                                    {40, {"int"}},
+                                    {10, {"double"}},
+                                    {20, {"double"}},
+                                    {30, {"double"}},
+                                    {40, {"double"}},
+                                    {1, {"array", "0"}},
+                                    {2, {"array", "1"}},
+                                    {3, {"array", "2"}}};
 
     auto schema = std::make_shared<Schema>();
     auto i64_fid = schema->AddDebugField("id", DataType::INT64);

diff --git a/tests/python_client/testcases/test_compaction.py b/tests/python_client/testcases/test_compaction.py
@@ -1145,6 +1145,7 @@ def test_compact_cross_partition(self):
             assert len(plan.sources) == 1
 
     @pytest.mark.tags(CaseLabel.L1)
+    @pytest.mark.skip("https://github.com/milvus-io/milvus/issues/31258")
     def test_compact_during_insert(self):
         """
         target: test compact during insert and flush