Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swiss locale thousands separator issue #1464

Closed
wants to merge 1 commit into from

Conversation

vorph1
Copy link

@vorph1 vorph1 commented Nov 25, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When using a Swiss locale (eg. en-CH), the numbers are formatted using a right single quotation marks (U+2019) and not apostrophes (U+0027) for thousands separator on Chrome, leading to NaN values being emitted via ngModel.

Issue Number: N/A

What is the new behavior?

Correct number values are emitted.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@andriikamaldinov1
Copy link
Collaborator

@vorph1 Thanks for using Ngx-mask.
There have been no such problems to date. You can expand the Ngx-mask config it example - https://stackblitz.com/edit/stackblitz-starters-lgtys9?file=package.json,src%2Fmain.ts

Thanks for Contributing. We closed this PR, if you have problems in the future open new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants