fix(1009): decimalMarker not locale default #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrpia Thank you for contributing. We just migrated to ng15 with standalone API. Please make reverse merge and recreate PR. Also if possible we need to add unit test. Lets try to discuss this question too. |
|
Awesome, I need this fix for my project too :) |
note: manually tested with added showcase "Decimal separator with existing value" of course, if someone finds a way to mock/set the locale in the tests, I'll gladly add a unit test for that :) to test: set browser locale to German for instance (so that decimal marker defaults to ',') before fix: 1234.56 shows as 1234.5 after fix: 1234.56 shows as 1234.56
e.g. FR locale uses comma (,) as decimal marker
mrpia
force-pushed
the
fix1009-delimiter-with-non-EN-US-browser-locale
branch
from
6710c48
to
8ed971c
Compare
|
sorry for the wait folks, so much project pressure, finally took the time to work on that, incl. added a unit test, tell me what you think |
|
@mrpia Thank you . We will look . We plan new release later next week. |
NepipenkoIgor
added a commit
that referenced
this pull request
Apr 27, 2023
* Fix/readme (#1057) * feat(no-ref): change readme * feat(no-ref): fix budge Co-authored-by: Igor Nepipenko <[email protected]> * build(deps): bump json5 from 1.0.1 to 1.0.2 (#1061) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump ua-parser-js from 0.7.32 to 0.7.33 (#1065) Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.32 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.32...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: typo in separator.ts (#1064) * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (#1067) Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(1069): input seleciontStart goes to wrong position after dynamic mask changes while typing (#1070) * fix(1069): input seleciontStart goes to wrong position after dynamic mask changes while typing * fix(1069): patch version, update changelog and lint files * fix(#1077): pipe no should work as directive (#1082) * fix(#1077): pipe no should work as directive * fix(#1077): reinstall deps --------- Co-authored-by: Igor Nepipenko <[email protected]> * Feature/v15.1.0 (#1084) * Fix/readme (#1057) (#1058) * feat(no-ref): change readme * feat(no-ref): fix budge Co-authored-by: Igor Nepipenko <[email protected]> Co-authored-by: Igor Nepipenko <[email protected]> * v15.0.3 (#1075) * Fix/readme (#1057) * feat(no-ref): change readme * feat(no-ref): fix budge Co-authored-by: Igor Nepipenko <[email protected]> * build(deps): bump json5 from 1.0.1 to 1.0.2 (#1061) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump ua-parser-js from 0.7.32 to 0.7.33 (#1065) Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.32 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.32...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: typo in separator.ts (#1064) * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (#1067) Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(1069): input seleciontStart goes to wrong position after dynamic mask changes while typing (#1070) * fix(1069): input seleciontStart goes to wrong position after dynamic mask changes while typing * fix(1069): patch version, update changelog and lint files --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Igor Nepipenko <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PradeepRaj <[email protected]> Co-authored-by: Mikael Augusto Boff <[email protected]> * feat(no-ref): reverse merge fron master v1 * feat(no-ref): reverse merge reformat changelog --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Igor Nepipenko <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PradeepRaj <[email protected]> Co-authored-by: Mikael Augusto Boff <[email protected]> * feat(no-ref): before reverse merge v15.0.1 * feat(no-ref): reverse merge v15.1.0 v1 * feature/demo_redesign: Delete mat-accordion, do it custom, add new styles * fix(no-ref): up deps and check lint * fix(no-ref): up deps and check lint * fix(no-ref): sync package lock v1 * fix(no-ref): tests should work * fix(no-ref): try to change code scan * fix(no-ref): try to change code scan v1 * fix(no-ref): try to change code scan v2 * fix(no-ref): remove codescan * fix(no-ref): try to change code scan v3 * feat(no-ref): Did new layout for header,sub-header,app-component, delete material from layout * feat(no-ref): fix layout and styles * feat(no-ref): fix layout and styles * feat(no-ref): fix layout and styles * feat(no-ref): fix layout and styles * feat(no-ref): fix few styles, and start do adaptive layout * feat(no-ref): Add responsive layout for header, sub-header,app-component * feat(no-ref): Add responsive layout for header, sub-header,app-component * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): did responsive layout, prepair for submodules * feat(no-ref): fix styles where was important and few fix with OnInit * feat(no-ref): fix styles where was important and few fix with OnInit * feat(no-ref): fix logic in accordion * feat(no-ref): fix logic in accordion * feat(no-ref): fix logic in accordion * feat(no-ref): fix app component * feat(no-ref): add reusable card-content * feat(no-ref): add variable to scss color * feat(no-ref): add required filds for component * feat(no-ref): add required filds for component * feat(no-ref): add required filds for component * feat(no-ref): fix few styles * feat(no-ref): add animation from open accrodion block * feat(no-ref): remove quit-logo button * feat(no-ref): add animation for accordion block * Feature/track by (#1100) * feat(no-ref): remove quit-logo button * feat(no-ref): add animation for accordion block * feat(no-ref): add trackBy for ngFor * feat(no-ref): change prefix and add submodule to project * feat(no-ref): change few files * feat(no-ref): change import * feat(no-ref): add ci parametr * feat(no-ref): change name file * feat(no-ref): remove angular-material * feat(no-ref): add command for gh-pages (#1102) * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes img view * feat(no-ref): fixes img view * feat(no-ref): fixes img view * feat(no-ref): fixes img view * feat(no-ref): fixes img view * fix(no-ref): fix imports and add new img * fix(no-ref): fix import * fix(no-ref): fix import * fix(no-ref): fix import * fix(no-ref): fix scroll and new item in accordion * fix(no-ref): fix scroll and new item in accordion * fix(no-ref): fix scroll and new item in accordion * fix(no-ref): remove class * fix(no-ref): add scroll img * fix(no-ref): add use strick comparison * fix(no-ref): change title * fix(no-ref): change title * fix(no-ref): fix scroll cards * fix(no-ref): fix scroll navigation * fix(no-ref): change naming * fix(no-ref): fix scroll and add anchor scroll * fix(no-ref): fix scroll and add anchor scroll * fix(no-ref): fix scroll and add anchor scroll * fix(no-ref): fix naming * fix(no-ref): fix naming and add unsubscriber * fix(no-ref): fix naming and add unsubscriber * fix(no-ref): fix naming and add unsubscriber * fix(no-ref): add click outside accordion * fix(no-ref): fix after qa * fix(no-ref): add meta description * fix(no-ref): add meta description * fix(no-ref): add meta description * fix(no-ref): close non public api (#1118) Co-authored-by: Igor Nepipenko <[email protected]> * fix(no-ref): uncommit package lock * fix(no-ref): sync package and lock file * fix(no-ref): sync package and lock file v1 * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * fix(1009): decimalMarker not locale default (#1052) * fix(1009): decimalMarker not locale default note: manually tested with added showcase "Decimal separator with existing value" of course, if someone finds a way to mock/set the locale in the tests, I'll gladly add a unit test for that :) to test: set browser locale to German for instance (so that decimal marker defaults to ',') before fix: 1234.56 shows as 1234.5 after fix: 1234.56 shows as 1234.56 * test(1009): test non EN locale e.g. FR locale uses comma (,) as decimal marker * fix(#1101): right flow for drop special character (#1126) * fix(#1101): right flow for drop special character * fix(#1101): right flow for drop special character v1 * fix(#1101): right flow for drop special character v2 --------- Co-authored-by: Igor Nepipenko <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Igor Nepipenko <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PradeepRaj <[email protected]> Co-authored-by: Mikael Augusto Boff <[email protected]> Co-authored-by: andriikamaldinov <[email protected]> Co-authored-by: Andrii Kamaldinov <[email protected]> Co-authored-by: Pierre-Arnaud Galiana <[email protected]>
NepipenkoIgor
added a commit
that referenced
this pull request
Nov 1, 2024
* v15.1.2 (#1127) * Fix/readme (#1057) * feat(no-ref): change readme * feat(no-ref): fix budge Co-authored-by: Igor Nepipenko <[email protected]> * build(deps): bump json5 from 1.0.1 to 1.0.2 (#1061) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump ua-parser-js from 0.7.32 to 0.7.33 (#1065) Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.32 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.32...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: typo in separator.ts (#1064) * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (#1067) Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(1069): input seleciontStart goes to wrong position after dynamic mask changes while typing (#1070) * fix(1069): input seleciontStart goes to wrong position after dynamic mask changes while typing * fix(1069): patch version, update changelog and lint files * fix(#1077): pipe no should work as directive (#1082) * fix(#1077): pipe no should work as directive * fix(#1077): reinstall deps --------- Co-authored-by: Igor Nepipenko <[email protected]> * Feature/v15.1.0 (#1084) * Fix/readme (#1057) (#1058) * feat(no-ref): change readme * feat(no-ref): fix budge Co-authored-by: Igor Nepipenko <[email protected]> Co-authored-by: Igor Nepipenko <[email protected]> * v15.0.3 (#1075) * Fix/readme (#1057) * feat(no-ref): change readme * feat(no-ref): fix budge Co-authored-by: Igor Nepipenko <[email protected]> * build(deps): bump json5 from 1.0.1 to 1.0.2 (#1061) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump ua-parser-js from 0.7.32 to 0.7.33 (#1065) Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.32 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.32...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: typo in separator.ts (#1064) * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (#1067) Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(1069): input seleciontStart goes to wrong position after dynamic mask changes while typing (#1070) * fix(1069): input seleciontStart goes to wrong position after dynamic mask changes while typing * fix(1069): patch version, update changelog and lint files --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Igor Nepipenko <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PradeepRaj <[email protected]> Co-authored-by: Mikael Augusto Boff <[email protected]> * feat(no-ref): reverse merge fron master v1 * feat(no-ref): reverse merge reformat changelog --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Igor Nepipenko <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PradeepRaj <[email protected]> Co-authored-by: Mikael Augusto Boff <[email protected]> * feat(no-ref): before reverse merge v15.0.1 * feat(no-ref): reverse merge v15.1.0 v1 * feature/demo_redesign: Delete mat-accordion, do it custom, add new styles * fix(no-ref): up deps and check lint * fix(no-ref): up deps and check lint * fix(no-ref): sync package lock v1 * fix(no-ref): tests should work * fix(no-ref): try to change code scan * fix(no-ref): try to change code scan v1 * fix(no-ref): try to change code scan v2 * fix(no-ref): remove codescan * fix(no-ref): try to change code scan v3 * feat(no-ref): Did new layout for header,sub-header,app-component, delete material from layout * feat(no-ref): fix layout and styles * feat(no-ref): fix layout and styles * feat(no-ref): fix layout and styles * feat(no-ref): fix layout and styles * feat(no-ref): fix few styles, and start do adaptive layout * feat(no-ref): Add responsive layout for header, sub-header,app-component * feat(no-ref): Add responsive layout for header, sub-header,app-component * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): check lint * feat(no-ref): did responsive layout, prepair for submodules * feat(no-ref): fix styles where was important and few fix with OnInit * feat(no-ref): fix styles where was important and few fix with OnInit * feat(no-ref): fix logic in accordion * feat(no-ref): fix logic in accordion * feat(no-ref): fix logic in accordion * feat(no-ref): fix app component * feat(no-ref): add reusable card-content * feat(no-ref): add variable to scss color * feat(no-ref): add required filds for component * feat(no-ref): add required filds for component * feat(no-ref): add required filds for component * feat(no-ref): fix few styles * feat(no-ref): add animation from open accrodion block * feat(no-ref): remove quit-logo button * feat(no-ref): add animation for accordion block * Feature/track by (#1100) * feat(no-ref): remove quit-logo button * feat(no-ref): add animation for accordion block * feat(no-ref): add trackBy for ngFor * feat(no-ref): change prefix and add submodule to project * feat(no-ref): change few files * feat(no-ref): change import * feat(no-ref): add ci parametr * feat(no-ref): change name file * feat(no-ref): remove angular-material * feat(no-ref): add command for gh-pages (#1102) * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes after QA * feat(no-ref): fixes img view * feat(no-ref): fixes img view * feat(no-ref): fixes img view * feat(no-ref): fixes img view * feat(no-ref): fixes img view * fix(no-ref): fix imports and add new img * fix(no-ref): fix import * fix(no-ref): fix import * fix(no-ref): fix import * fix(no-ref): fix scroll and new item in accordion * fix(no-ref): fix scroll and new item in accordion * fix(no-ref): fix scroll and new item in accordion * fix(no-ref): remove class * fix(no-ref): add scroll img * fix(no-ref): add use strick comparison * fix(no-ref): change title * fix(no-ref): change title * fix(no-ref): fix scroll cards * fix(no-ref): fix scroll navigation * fix(no-ref): change naming * fix(no-ref): fix scroll and add anchor scroll * fix(no-ref): fix scroll and add anchor scroll * fix(no-ref): fix scroll and add anchor scroll * fix(no-ref): fix naming * fix(no-ref): fix naming and add unsubscriber * fix(no-ref): fix naming and add unsubscriber * fix(no-ref): fix naming and add unsubscriber * fix(no-ref): add click outside accordion * fix(no-ref): fix after qa * fix(no-ref): add meta description * fix(no-ref): add meta description * fix(no-ref): add meta description * fix(no-ref): close non public api (#1118) Co-authored-by: Igor Nepipenko <[email protected]> * fix(no-ref): uncommit package lock * fix(no-ref): sync package and lock file * fix(no-ref): sync package and lock file v1 * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * feat(no-ref): redisign * fix(1009): decimalMarker not locale default (#1052) * fix(1009): decimalMarker not locale default note: manually tested with added showcase "Decimal separator with existing value" of course, if someone finds a way to mock/set the locale in the tests, I'll gladly add a unit test for that :) to test: set browser locale to German for instance (so that decimal marker defaults to ',') before fix: 1234.56 shows as 1234.5 after fix: 1234.56 shows as 1234.56 * test(1009): test non EN locale e.g. FR locale uses comma (,) as decimal marker * fix(#1101): right flow for drop special character (#1126) * fix(#1101): right flow for drop special character * fix(#1101): right flow for drop special character v1 * fix(#1101): right flow for drop special character v2 --------- Co-authored-by: Igor Nepipenko <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Igor Nepipenko <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PradeepRaj <[email protected]> Co-authored-by: Mikael Augusto Boff <[email protected]> Co-authored-by: andriikamaldinov <[email protected]> Co-authored-by: Andrii Kamaldinov <[email protected]> Co-authored-by: Pierre-Arnaud Galiana <[email protected]> * fix(#1103): fix 1103 * fix(#1103): fix 1103 * fix(#1078): fix 1078 * fix(#1078): fix 1078 * Feat/ng16 (#1144) (#1145) * fix(no-ref): before update * fix(no-ref): ng 16 * fix(no-ref): remove non need in this moment deps --------- Co-authored-by: Igor Nepipenko <[email protected]> * fix(#1071): fix 1071 * fix(#1200): fix 1200 * fix(#658): fix 658 * fix(#658): fix 658 * feat(no-ref): up deps (#1363) * feat(ref: no-ref): add setup hooks, remove karma (#1340) * feat(ref: no-ref): add setup hooks, remove carma * feat(ref: no-ref): remove environment * feat(ref: no-ref): fix warnings in console * feat(ref: no-ref): remove cypress from lib folder * feat(ref: no-ref): add text to readme * build(deps-dev): bump undici from 5.28.3 to 5.28.4 (#1343) Bumps [undici](https://github.com/nodejs/undici) from 5.28.3 to 5.28.4. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.3...v5.28.4) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump tar and npm (#1346) Bumps [tar](https://github.com/isaacs/node-tar) and [npm](https://github.com/npm/cli). These dependencies needed to be updated together. Updates `tar` from 6.1.14 to 6.2.1 - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.14...v6.2.1) Updates `npm` from 10.5.0 to 10.5.2 - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](npm/cli@v10.5.0...v10.5.2) --- updated-dependencies: - dependency-name: tar dependency-type: indirect - dependency-name: npm dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump undici and @angular-devkit/build-angular (#1351) Bumps [undici](https://github.com/nodejs/undici) to 6.11.1 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together. Updates `undici` from 6.7.1 to 6.11.1 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.7.1...v6.11.1) Updates `@angular-devkit/build-angular` from 17.3.0 to 17.3.4 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@17.3.0...17.3.4) --- updated-dependencies: - dependency-name: undici dependency-type: indirect - dependency-name: "@angular-devkit/build-angular" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(no-ref): update deps (#1353) * feat(no-ref): update deps * feat(no-ref): update deps v1 * fix(1358): add trailing zero when mask="separator.1" and leadZero="true" (#1359) Currently, no trailing zero is added when mask="separator.1" and leadZero="true" and input loses focus. This change adds the trailing zero in that case. * feat(no-ref): up deps (#1362) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Andrii Kamaldinov <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nathaniel Buck <[email protected]> * fix(ref: no-ref): fix issues * fix(ref: no-ref): fix issues * fix(ref: no-ref): fix bugs * fix(ref: no-ref): fix bugs * feat(ref: no-ref): fix issue * feat(ref: no-ref): fix issue * feat(ref: no-ref): fix issue * feat(ref: no-ref): fix issue * fix(ref: no-ref): fix issue * fix(ref: no-ref): fix issue * fix(ref: no-ref): fix issue * fix(ref: no-ref): fix issue * fix(ref: no-ref): fix issue * fix(ref: no-ref): fix issue * feat(ref: no-ref): up-deps * feat(ref: no-ref): up-deps * feat(ref: no-ref): up-deps * fix(ref:no-ref): add cache folder to ignore * fix(ref:no-ref): add cache folder to ignore v1 * feat(ref: no-ref): add more timeout to cypress --------- Co-authored-by: NepipenkoIgor <[email protected]> * fix(ref: no-ref): release * fix(ref: no-ref): fix issues * fix(ref: no-ref): fix issues * fix(ref: no-ref): fix issues * fix(ref: no-ref): fix issues --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Igor Nepipenko <[email protected]> Co-authored-by: Igor Nepipenko <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: PradeepRaj <[email protected]> Co-authored-by: Mikael Augusto Boff <[email protected]> Co-authored-by: Pierre-Arnaud Galiana <[email protected]> Co-authored-by: Nathaniel Buck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: rebased on latest develop, added a test with FR locale (uses comma as decimal marker)
to reproduce the issue:
before fix: 1234.56 shows as 1234.5
after fix: 1234.56 shows as 1234.56
added unit test:
separator-non-en-locale.spec.ts, which fails without the code change (you can simply letNgxMaskDirective._currentLocaleDecimalMarkerreturn '.' and see it fail).PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1009
before fix: 1234.56 shows as 1234.5
What is the new behavior?
after fix: 1234.56 shows as 1234.56
Does this PR introduce a breaking change?
Other information
fixes #1009