-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/petra ci checks #5157
Fix/petra ci checks #5157
Conversation
2783470
to
e53fabb
Compare
e53fabb
to
9f42316
Compare
it was giving weird babel errors, so temporarely I am upgrading this dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -299,7 +372,7 @@ export class CreateProposalsFixture extends StandardizedFixture { | |||
} | |||
|
|||
protected assertQueryNodeEventIsValid(qEvent: ProposalCreatedEventFieldsFragment, i: number): void { | |||
// TODO: https://github.com/Joystream/joystream/issues/2457 | |||
// Inetntionally left blank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Intentionally"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SSIA:
Argo pallet update constraints network test case will be added soon in a future PR