Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mainnet: liberated runtime (drop sudo pallet) #4478

Merged
merged 13 commits into from
Dec 6, 2022
Merged

Mainnet: liberated runtime (drop sudo pallet) #4478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6eb9ea1
supervised runtime
mnaamani Nov 30, 2022
ded6065
mainnet liberated runtime - remove Call on sudo pallet
mnaamani Nov 30, 2022
2d9159c
update chain metadata
mnaamani Nov 30, 2022
64d99f6
bump types version to v0.20.6
mnaamani Dec 1, 2022
a42dd6c
remove comments
mnaamani Dec 1, 2022
a4de019
drop sudo pallet from runtime
mnaamani Dec 1, 2022
fe39bbb
Merge branch 'mainnet-liberated-runtime' into mainnet-liberated-runti…
mnaamani Dec 1, 2022
7c44e18
update chain metadata
mnaamani Dec 1, 2022
57d1a31
drop sudo pallet and storage dev dispatchables
mnaamani Dec 5, 2022
ae88679
remove sudo calls from storage and distributor nodes
mnaamani Dec 5, 2022
24c465b
remove sudo account setup from devops and github workflows
mnaamani Dec 5, 2022
6443552
run partial integration tests
mnaamani Dec 5, 2022
635d1ad
drop more reference to sudo, make integration tests pass
mnaamani Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion chain-metadata.json
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 1 addition & 17 deletions runtime-modules/storage/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ use frame_support::{
storage::{bounded_btree_set::BoundedBTreeSet, bounded_vec::BoundedVec},
IterableStorageDoubleMap, PalletId, Parameter,
};
use frame_system::{ensure_root, ensure_signed};
use frame_system::ensure_signed;
use scale_info::TypeInfo;
#[cfg(feature = "std")]
use serde::{Deserialize, Serialize};
Expand Down Expand Up @@ -3049,22 +3049,6 @@ decl_module! {
);
}

/// Upload new data objects. Development mode.
#[weight = 10_000_000]
pub fn sudo_upload_data_objects(origin, params: UploadParameters<T>) {
ensure_root(origin)?;

//
// == MUTATION SAFE ==
//

if cfg!(feature = "playground-runtime") || cfg!(feature = "testing-runtime") {
Self::upload_data_objects(params)?;
} else {
return Err(Error::<T>::CallDisabled.into());
}
}

/// Create a dynamic bag. Development mode.
/// <weight>
///
Comment on lines 3052 to 3054
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed there's a leftover comment

Suggested change
/// Create a dynamic bag. Development mode.
/// <weight>
///

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny this comment is wrong for the function :) will fix.

Expand Down
2 changes: 0 additions & 2 deletions runtime/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ pallet-session = { package = 'pallet-session', features = [ "historical" ], defa
pallet-offences = { package = 'pallet-offences', default-features = false, git = 'https://github.com/joystream/substrate.git', rev = 'd29a53b11c3e530d1656eef502cb0f1f8fff3522'}
pallet-randomness-collective-flip = { package = 'pallet-randomness-collective-flip', default-features = false, git = 'https://github.com/joystream/substrate.git', rev = 'd29a53b11c3e530d1656eef502cb0f1f8fff3522'}
pallet-authority-discovery = { package = 'pallet-authority-discovery', default-features = false, git = 'https://github.com/joystream/substrate.git', rev = 'd29a53b11c3e530d1656eef502cb0f1f8fff3522'}
pallet-sudo = { package = 'pallet-sudo', default-features = false, git = 'https://github.com/joystream/substrate.git', rev = 'd29a53b11c3e530d1656eef502cb0f1f8fff3522'}
pallet-staking = { package = 'pallet-staking', default-features = false, git = 'https://github.com/joystream/substrate.git', rev = 'd29a53b11c3e530d1656eef502cb0f1f8fff3522'}
pallet-timestamp = { package = 'pallet-timestamp', default-features = false, git = 'https://github.com/joystream/substrate.git', rev = 'd29a53b11c3e530d1656eef502cb0f1f8fff3522'}
pallet-balances = { package = 'pallet-balances', default-features = false, git = 'https://github.com/joystream/substrate.git', rev = 'd29a53b11c3e530d1656eef502cb0f1f8fff3522'}
Expand Down Expand Up @@ -145,7 +144,6 @@ std = [
'pallet-authorship/std',
'pallet-randomness-collective-flip/std',
'pallet-staking/std',
'pallet-sudo/std',
'pallet-im-online/std',
'pallet-offences/std',
'pallet-vesting/std',
Expand Down
Loading