🛑 Stop polling if notifications recipient is undefined (Joystream#5695)

Joystream · Dec 29, 2023 · 2227dcc · 2227dcc
1 parent e3e000d
commit 2227dcc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/atlas/src/providers/notifications/notifications.hooks.ts b/packages/atlas/src/providers/notifications/notifications.hooks.ts
@@ -32,6 +32,7 @@ export type UseNotifications = Pick<QueryResult<GetNotificationsConnectionQuery>
   setLastSeenNotificationDate: (data: Date) => void
   markNotificationsAsRead: (notifications: NotificationRecord[]) => void
   pageInfo?: GetNotificationsConnectionQuery['notificationsConnection']['pageInfo']
+  recipient: RecipientTypeWhereInput | undefined
 }
 
 export const useNotifications = (opts?: Pick<QueryHookOptions, 'notifyOnNetworkStatusChange'>): UseNotifications => {
@@ -120,6 +121,7 @@ export const useNotifications = (opts?: Pick<QueryHookOptions, 'notifyOnNetworkS
     unseenNotificationsCounts,
     setLastSeenNotificationDate,
     markNotificationsAsRead,
+    recipient,
   }
 }
 

diff --git a/packages/atlas/src/providers/notifications/notifications.manager.tsx b/packages/atlas/src/providers/notifications/notifications.manager.tsx
@@ -5,10 +5,14 @@ import { atlasConfig } from '@/config'
 import { useNotifications } from './notifications.hooks'
 
 export const NotificationsManager: FC = () => {
-  const { fetchMore, unseenNotificationsCounts } = useNotifications()
+  const { fetchMore, unseenNotificationsCounts, recipient } = useNotifications()
 
   useEffect(() => {
     const id = setInterval(() => {
+      if (!recipient) {
+        return
+      }
+
       unseenNotificationsCounts.fetchMore()
       fetchMore({
         updateQuery: (prev, { fetchMoreResult }) => {
@@ -44,7 +48,7 @@ export const NotificationsManager: FC = () => {
       clearInterval(id)
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [fetchMore, unseenNotificationsCounts.fetchMore])
+  }, [fetchMore, unseenNotificationsCounts.fetchMore, !recipient])
 
   return null
 }