Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab for multi arch in history page #134

Merged
merged 4 commits into from
Jun 11, 2020
Merged

Add tab for multi arch in history page #134

merged 4 commits into from
Jun 11, 2020

Conversation

Joxit
Copy link
Owner

@Joxit Joxit commented Jun 8, 2020

Feature

This PR add the support for multi-arch images.

Screenshoot

multi-arch

@bjj: This style is OK for you ?

closes #130

@bjj
Copy link

bjj commented Jun 8, 2020

Looks good. I assume the hardcoded arch list is just to make the mockup?

@Joxit
Copy link
Owner Author

Joxit commented Jun 8, 2020

Yes, this is a mock for the style only, I will continue the PR ASAP 😄

@Joxit
Copy link
Owner Author

Joxit commented Jun 10, 2020

I added the behaviour for multi arch images. Can you test it ?

@bjj
Copy link

bjj commented Jun 10, 2020

Built with:

docker build -t joxit/docker-registry-ui:static -f static.dockerfile https://github.com/Joxit/docker-registry-ui.git#feat/multi-arch

Notes:

  • Each time I go to the history page, I don't see tabs until I reload once. If I keep reloading, I keep getting tabs. If I go back to the image list and hit the history icon again, I have no tabs.
  • When switching tabs, the sort order of the elements below changes sometimes. Some of the layers are created in the same second, but the order changes even for items with distinct creation times.

Other than that, it seems to work, and show me different things for the different archs.

(side note: it would be nice if "created" and "created by" (and other common fields) appeared in the same layout in each history block to make scanning by eye easier)

@Joxit
Copy link
Owner Author

Joxit commented Jun 10, 2020

Thank you for your feedback !
I have the same behaviour, I know how to fix the first one, the second is a bit weird 🤷‍♂️ I'm on it !

So the order will be Created => Created by => id for example ?

@bjj
Copy link

bjj commented Jun 10, 2020

I'm not sure what the best order is. Created by / Created time seem like good places to start. Anything that makes it easier to scan down the list than this:

image

@Joxit
Copy link
Owner Author

Joxit commented Jun 10, 2020

I think I fixed the two issues!

The new order is Created, Created By, Size and then ID.
Created and Created By are always present.
ID and Size are always present together.
I like the ID in the left side on full screen and sticky in the same zone.

Here is the result:
image

… times

no arch when the landing page is not tag history
reorder history elements
@bjj
Copy link

bjj commented Jun 10, 2020

Last change fixes all of the issues I saw. Tabs appear on first load, and order is stable when flipping tabs. It's much easier to flip between them to see what's changing, and easier to skim down the list to find the relevant history 👍

@Joxit
Copy link
Owner Author

Joxit commented Jun 11, 2020

Yeaaah cool ! 😄 thank you again for your feedback !

@Joxit Joxit merged commit c9ede6f into master Jun 11, 2020
@Joxit Joxit deleted the feat/multi-arch branch June 11, 2020 07:34
@github-pages github-pages bot temporarily deployed to github-pages June 11, 2020 07:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't see all architectures associated with a tag
2 participants