Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Remove excess whitespace and use more std algorithms #5

Merged
merged 1 commit into from
May 4, 2014

Conversation

kanielc
Copy link
Collaborator

@kanielc kanielc commented May 4, 2014

A few tiny refactorings and removing some excess whitespace.

A few tiny refactorings and removing some excess whitespace.
@JossWhittle JossWhittle merged commit 6ed6425 into JossWhittle:master May 4, 2014
@JossWhittle
Copy link
Owner

Great work, just be careful that the use of std:: functions doesn't begin to obfuscate the code. I like the addition of the delete functions on the tokenizer, hopefully people wouldn't be changing how it's called but I like the safety mechanism this adds.

@kanielc
Copy link
Collaborator Author

kanielc commented May 4, 2014

I agree.   Sometimes those calls can get cryptic.   I'm done those now though. I can look to help with some of the remaining features.   I can do some things with the tests too.

Sent from Samsung Mobile

-------- Original message --------
From: Joss Whittle [email protected]
Date:05/04/2014 9:18 AM (GMT-05:00)
To: L2Program/FlintPlusPlus [email protected]
Cc: Denton Cockburn [email protected]
Subject: Re: [FlintPlusPlus] Remove excess whitespace and use more std
algorithms (#5)

Great work, just be careful that the use of std:: functions doesn't begin to obfuscate the code. I like the addition of the delete functions on the tokenizer, hopefully people wouldn't be changing how it's called but I like the safety mechanism this adds.


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants