Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base.:+ and Base.:* for kernels #45

Merged
merged 2 commits into from
May 5, 2024

Conversation

JoshuaLampert
Copy link
Owner

@JoshuaLampert JoshuaLampert commented May 5, 2024

Add convenience functions to add and multiply kernels. Wrap them automatically as SumKernel and ProductKernel. The same for TransformationKernel and Base.:∘ is more involved since we would need to infer the input dimension of the transformation because this is the new dimension Dim of the kernel (the output dimension of the transformation is the input dimension of the base kernel and thus known).

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (a72dbdf) to head (3893b62).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          32       32           
  Lines         933      935    +2     
=======================================
+ Hits          921      923    +2     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert JoshuaLampert merged commit 231f03c into main May 5, 2024
14 checks passed
@JoshuaLampert JoshuaLampert deleted the add-multiply-compose-kernels branch May 5, 2024 16:09
@JoshuaLampert JoshuaLampert added the enhancement New feature or request label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant