Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Support arrow functions too #2

Closed
3 tasks done
JoshuaKGoldberg opened this issue Oct 3, 2022 · 1 comment · Fixed by #181
Closed
3 tasks done

🚀 Feature: Support arrow functions too #2

JoshuaKGoldberg opened this issue Oct 3, 2022 · 1 comment · Fixed by #181
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, the source code is only built to check that function declarations are supported:

function isNotFalsy(value: unknown) {
	return !!value;
}

I haven't yet bothered to add in support for arrow functions:

const isNotFalsy = (value: unknown) => !!value;

...someone could do that 😄

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request 🚀 status: accepting prs Please, send a pull request to resolve this! 🙏 labels Oct 3, 2022
This was referenced Jun 3, 2024
Closed
Merged
JoshuaKGoldberg added a commit that referenced this issue Jun 3, 2024
@JoshuaKGoldberg
feat: support arrow functions (#181)
5a89f08 
## PR Checklist

- [x] Addresses an existing open issue: fixes #2
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/ts-function-inliner/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/ts-function-inliner/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removes the now-outdated assumption that functions always have a `body`
with `statements`.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

🎉 This is included in version v0.2.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support arrow functions JoshuaKGoldberg/ts-function-inliner
1 participant
@JoshuaKGoldberg