Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add unit tests #23

Open
JoshuaKGoldberg opened this issue Jan 25, 2020 · 1 comment
Open

Re-add unit tests #23

JoshuaKGoldberg opened this issue Jan 25, 2020 · 1 comment
Assignees
@JoshuaKGoldberg
Labels
type: cleanup Tech debt or other code/repository cleanups 🧹

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Jan 25, 2020 •
edited
Loading

Blocked on #20: I'd like to restructure this, then unit test it.
@JoshuaKGoldberg JoshuaKGoldberg added type: cleanup Tech debt or other code/repository cleanups 🧹 status: blocked Waiting for something else to be resolved 🙅 labels Jan 25, 2020
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 26, 2020
@JoshuaKGoldberg JoshuaKGoldberg removed the status: blocked Waiting for something else to be resolved 🙅 label Jan 26, 2020
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 26, 2020
Merged
@JoshuaKGoldberg
Copy link
Owner Author

#31 added lower level ones. I'd still like to add some high level ones for the time logic. That's pretty much the App component.

This'll be a chance to play around with the useGlobals hook!

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 26, 2020
Merged
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
type: cleanup Tech debt or other code/repository cleanups 🧹
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg