Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use React Context for settings #20

Closed
JoshuaKGoldberg opened this issue Jan 23, 2020 · 1 comment
Closed

Use React Context for settings #20

JoshuaKGoldberg opened this issue Jan 23, 2020 · 1 comment
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: cleanup Tech debt or other code/repository cleanups 🧹

Comments

@JoshuaKGoldberg
Copy link
Owner

User settings such as time and beeps are enabled is basically application-level data. I'd like to move it to Context so we don't have to drill them down through multiple components to get down to where they're needed.
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 type: cleanup Tech debt or other code/repository cleanups 🧹 labels Jan 23, 2020
This was referenced Jan 25, 2020
Open
Merged
@JoshuaKGoldberg
Copy link
Owner Author

Mmhh, I tried it out for settings too but didn't quite like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: cleanup Tech debt or other code/repository cleanups 🧹
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg