Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly handle IfStatement's alternate branch #86

Merged
merged 8 commits into from
Sep 5, 2023
Merged

fix: correctly handle IfStatement's alternate branch #86

merged 8 commits into from
Sep 5, 2023

Conversation

so1ve
Copy link
Contributor

@so1ve so1ve commented Sep 5, 2023 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #86 (cf60147) into main (fe0cd38) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        29    +4     
  Branches         6        10    +4     
=========================================
+ Hits            25        29    +4
Files Changed Coverage Δ
src/printNodeWithBrackets.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@so1ve so1ve changed the title fix: correctly handle blockstatement inside alternate branch fix: correctly handle BlockStatement inside alternate branch Sep 5, 2023
auvred
auvred reviewed Sep 5, 2023
View reviewed changes
@so1ve so1ve changed the title fix: correctly handle BlockStatement inside alternate branch fix: correctly handle IfStatement's alternate branch Sep 5, 2023
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 5, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honestly surprised this hasn't come up yet 😄 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit b39b667 into JoshuaKGoldberg:main Sep 5, 2023
@so1ve so1ve deleted the fix/if-alternate-blockstatement branch September 5, 2023 13:19
@so1ve
Copy link
Contributor Author

so1ve commented Sep 5, 2023

Ugh! You forgot to use squash merge :P

@JoshuaKGoldberg
Copy link
Owner

Oh nooooo it's supposed to be set by default on all my repos! #83

I'll rewrite Git history, one moment... 😄

JoshuaKGoldberg added a commit that referenced this pull request Sep 5, 2023
@JoshuaKGoldberg
fix: correctly handle blockstatement (#86)
5c71c8e
JoshuaKGoldberg pushed a commit that referenced this pull request Sep 5, 2023
@so1ve @JoshuaKGoldberg
fix: correctly handle blockstatement (#86)
622c259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvred auvred auvred left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: If and else branch is printed incorrectly
3 participants
@so1ve @JoshuaKGoldberg @auvred