Skip to content

Commit

Permalink
chore: match .all-contributorsrc to template (#1140)
Browse files Browse the repository at this point in the history
## PR Checklist

- [x] Addresses an existing open issue: fixes #1086
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Corrects the emojis and indentation in the `badgeTemplate` property.

Also sets `commitType` manually per #1090 - leaving the issue open.
  • Loading branch information
JoshuaKGoldberg authored Dec 30, 2023
1 parent 7390c17 commit b0f43d7
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 20 deletions.
6 changes: 3 additions & 3 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"badgeTemplate": "<a href=\"#contributors\" target=\"_blank\"><img alt=\"All Contributors: <%= contributors.length %> 🤝\" src=\"https://img.shields.io/badge/all_contributors-<%= contributors.length %>_🤝-21bb42.svg\" /></a>",
"badgeTemplate": "\t<a href=\"#contributors\" target=\"_blank\"><img alt=\"All Contributors: <%= contributors.length %> 👪\" src=\"https://img.shields.io/badge/all_contributors-<%= contributors.length %>_👪-21bb42.svg\" /></a>",
"commit": false,
"commitConvention": "angular",
"commitType": "docs",
"contributors": [
{
"avatar_url": "https://avatars.githubusercontent.com/u/3335181?v=4",
Expand Down Expand Up @@ -381,6 +382,5 @@
"projectName": "create-typescript-app",
"projectOwner": "JoshuaKGoldberg",
"repoHost": "https://github.com",
"repoType": "github",
"commitType": "docs"
"repoType": "github"
}
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<p align="center">
<!-- prettier-ignore-start -->
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
<a href="#contributors" target="_blank"><img alt="All Contributors: 39 🤝" src="https://img.shields.io/badge/all_contributors-39_🤝-21bb42.svg" /></a>
<a href="#contributors" target="_blank"><img alt="All Contributors: 39 👪" src="https://img.shields.io/badge/all_contributors-39_👪-21bb42.svg" /></a>
<!-- ALL-CONTRIBUTORS-BADGE:END -->
<!-- prettier-ignore-end -->
<a href="https://codecov.io/gh/JoshuaKGoldberg/create-typescript-app" target="_blank"><img alt="Codecov Test Coverage" src="https://codecov.io/gh/JoshuaKGoldberg/create-typescript-app/branch/main/graph/badge.svg"/></a>
Expand Down
20 changes: 4 additions & 16 deletions script/__snapshots__/migrate-test-e2e.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,7 @@
exports[`verify .all-contributorsrc 1`] = `
"--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -1,5 +1,5 @@
{
- "badgeTemplate": "<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"All Contributors: <%= contributors.length %> 🤝\\" src=\\"https://img.shields.io/badge/all_contributors-<%= contributors.length %>_🤝-21bb42.svg\\" /></a>",
+ "badgeTemplate": "\\t<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"All Contributors: <%= contributors.length %> 👪\\" src=\\"https://img.shields.io/badge/all_contributors-<%= contributors.length %>_👪-21bb42.svg\\" /></a>",
"commit": false,
"commitConvention": "angular",
"contributors": [
@@ -24,363 +24,274 @@
@@ -25,359 +25,271 @@
"name": "Jeff Wen",
"avatar_url": "https://avatars.githubusercontent.com/u/3297859?v=4",
"profile": "https://sinchang.me",
Expand Down Expand Up @@ -408,12 +401,7 @@ exports[`verify .all-contributorsrc 1`] = `
+ "files": ["README.md"],
"imageSize": 100,
"projectName": "create-typescript-app",
"projectOwner": "JoshuaKGoldberg",
"repoHost": "https://github.com",
- "repoType": "github",
- "commitType": "docs"
+ "repoType": "github"
}"
"projectOwner": "JoshuaKGoldberg","
`;

exports[`verify .eslintignore 1`] = `
Expand Down Expand Up @@ -649,7 +637,7 @@ exports[`verify README.md 1`] = `
<p align="center">
<!-- prettier-ignore-start -->
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
-<a href="#contributors" target="_blank"><img alt="All Contributors: 39 🤝" src="https://img.shields.io/badge/all_contributors-39_🤝-21bb42.svg" /></a>
- <a href="#contributors" target="_blank"><img alt="All Contributors: 39 👪" src="https://img.shields.io/badge/all_contributors-39_👪-21bb42.svg" /></a>
+ <a href="#contributors" target="_blank"><img alt="All Contributors: 39 👪" src="https://img.shields.io/badge/all_contributors-39_👪-21bb42.svg" /></a>
<!-- ALL-CONTRIBUTORS-BADGE:END -->
<!-- prettier-ignore-end -->
Expand All @@ -665,7 +653,7 @@ exports[`verify README.md 1`] = `
+ <img alt="Style: Prettier" src="https://img.shields.io/badge/style-prettier-21bb42.svg" />
+ <img alt="TypeScript: Strict" src="https://img.shields.io/badge/typescript-strict-21bb42.svg" />
<img alt="npm package version" src="https://img.shields.io/npm/v/create-typescript-app?color=21bb42" />
+ <a href="#contributors" target="_blank"><img alt="All Contributors: 39 🤝" src="https://img.shields.io/badge/all_contributors-39_🤝-21bb42.svg" /></a>
+ <a href="#contributors" target="_blank"><img alt="All Contributors: 39 👪" src="https://img.shields.io/badge/all_contributors-39_👪-21bb42.svg" /></a>
+ <img alt="Sponsor: On GitHub 💸" src="https://img.shields.io/badge/sponsor-on_github_💸-21bb42.svg" />
</p>
Expand Down
1 change: 1 addition & 0 deletions src/steps/writing/creation/writeAllContributorsRC.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export async function writeAllContributorsRC(options: Options) {
' <a href="#contributors" target="_blank"><img alt="All Contributors: <%= contributors.length %> 👪" src="https://img.shields.io/badge/all_contributors-<%= contributors.length %>_👪-21bb42.svg" /></a>',
commit: false,
commitConvention: "angular",
commitType: "docs",
contributors: existing?.contributors ?? [],
contributorsPerLine: 7,
contributorsSortAlphabetically: true,
Expand Down

0 comments on commit b0f43d7

Please sign in to comment.