Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Recognize Co-authored-by in issues #252

Closed
3 tasks done
JoshuaKGoldberg opened this issue Feb 22, 2024 · 0 comments · Fixed by #445
Closed
3 tasks done

🚀 Feature: Recognize Co-authored-by in issues #252

JoshuaKGoldberg opened this issue Feb 22, 2024 · 0 comments · Fixed by #445
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Feb 22, 2024 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, this library can detect Co-authored-by in commits and pull request descriptions. Which is nice for detecting code contributions. But, what about issues that should give attribution to multiple people? There's no equivalent standard I know of.

Proposal: let's expand Co-authored-by: support to issues. So that any attribution given to an issue's author will be given to co-authors as well.

Additional Info

I do feel a little awkward trying to establish a new comment/description precedence that, for now, is basically unique to my repositories... but nobody else had any ideas about this when I posted online (Bluesky post, Mastodon post, Twitter post). 😄 🤷

...I do wonder if this means that https://github.com/JoshuaKGoldberg/commit-to-co-authors will need to be renamed to something like description-to-co-authors. 🤔
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request labels Feb 22, 2024
This was referenced Aug 10, 2024
Closed
Merged
JoshuaKGoldberg added a commit that referenced this issue Aug 10, 2024
@JoshuaKGoldberg
feat: retrieve issue co-authors (#445)
e761182 
## PR Checklist

- [x] Addresses an existing open issue: fixes #252
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/all-contributors-for-repository/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/all-contributors-for-repository/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds in the same co-author detection using `description-to-co-authors`
for issue bodies as commit bodies.

💖
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: retrieve issue co-authors JoshuaKGoldberg/all-contributors-for-repository
1 participant
@JoshuaKGoldberg