Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 Tests: Enable suppressTypeErrors on all integration tests #1548

Closed
3 tasks done
rubiesonthesky opened this issue Apr 7, 2024 · 1 comment · Fixed by #1549
Closed
3 tasks done

🧪 Tests: Enable suppressTypeErrors on all integration tests #1548

rubiesonthesky opened this issue Apr 7, 2024 · 1 comment · Fixed by #1549
Labels
area: testing Improving how the repository's tests are run and/or code is tested 🧪 area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏

Comments

@rubiesonthesky
Copy link
Collaborator

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

By enabling suppressTypeErrors on all integration tests, we can easily see when there is non-valid code generated.

We can see and fix following problems

  • Incorrect compilerOptions.
  • Bugs / missing fixes
  • More examples of possible ts-expect-error comments

Additional Info

No response
@rubiesonthesky rubiesonthesky added area: tooling Managing the repository's maintenance 🛠️ area: testing Improving how the repository's tests are run and/or code is tested 🧪 labels Apr 7, 2024
@rubiesonthesky rubiesonthesky mentioned this issue Apr 7, 2024
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! 🙏 label Jan 3, 2025
JoshuaKGoldberg pushed a commit that referenced this issue Jan 3, 2025
@rubiesonthesky
test: enable suppressTypeErrors on all integration tests (#1549)
aa1d480 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1548
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/TypeStat/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/TypeStat/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Enables `suppressTypeErrors` on all integration tests to track potential
type errors on generated code.

Also, makes sure that we do not add absolute module path to the ts
ignore comment as it would be different when run on different machines.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.8.9 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: testing Improving how the repository's tests are run and/or code is tested 🧪 area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: enable suppressTypeErrors on all integration tests rubiesonthesky/TypeStat
2 participants
@rubiesonthesky @JoshuaKGoldberg