mypy: stricter settings #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tamird
commented
May 9, 2024
tamird
commented
- Ratchet up mypy settings
- Fix typo
- mypy: disallow_untyped_defs
- mypy: disallow_untyped_calls
tamird
force-pushed
the
mypy-stricter
branch
2 times, most recently
from
9084a5a to
d5aaabb
Compare
|
@JoshData would you mind approving another CI run? I though I had pushed earlier but evidently had not. |
|
@JoshData thanks! Green now. |
JoshData
reviewed
May 9, 2024
email_validator/deliverability.py
Outdated
| @@ -1,4 +1,5 @@ | |||
| from typing import Any, Dict, Optional | |||
| from typing import Any, List, Optional, Tuple, TypedDict | |||
| from typing_extensions import NotRequired | |||
There was a problem hiding this comment.
typing_extensions is available for tests because it's in the test_requirements.txt file but it's not in the main requirements list.
There was a problem hiding this comment.
Done (added to the main requirements list).
There was a problem hiding this comment.
Can we use total=False on the TypedDict definition so that NotRequired isn't necessary, and then the new dependency doesn't need to be added?
|
Very cool. Thanks very much. I left one comment. |
|
Thanks. I learned a lot from this, which I love. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.