Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file_operations instatiation #256

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

lgwacker
Copy link
Contributor

@lgwacker lgwacker commented May 8, 2023

Description

I got the problem with the commands, that was only happening with file_operations.
file_operations methods use one another to achive its goal. The problem is that we don't instantiate the class.

in the commands.py:119, we used to pass the module as a parameter. That will not work for modules on commands where one method depends on the other (since there is no self)
I will up a workaround for that, specific for file_operations, but we need to change the way its done.

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • New feature (prefix: feat - non-breaking change which adds functionality)
  • Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
  • Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change requires a change to the documentation.
  • My change works!

@Josh-XT Josh-XT merged commit 24f350a into Josh-XT:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants