Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes - Commands, Fix no objective situation #150

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Bugfixes - Commands, Fix no objective situation #150

merged 2 commits into from
Apr 28, 2023

Conversation

Josh-XT
Copy link
Owner

@Josh-XT Josh-XT commented Apr 28, 2023

Description

Updating Commands.py to fix find_command and execute_command params.

Motivation and Context

Should solve the commands not working, needs testing. May fix functionality for broken commands.

How has this been tested?

App.py runs and doesn't error - not tested past that.

Screenshots (if appropriate)

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • New feature (prefix: feat - non-breaking change which adds functionality)
  • Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
  • Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

  • [ x] My code follows the code style of this project and passes yarn run lint.
  • My change requires a change to the documentation.
  • My change works!

@Josh-XT Josh-XT merged commit aa22ca5 into main Apr 28, 2023
@Josh-XT Josh-XT deleted the bugfixes-1 branch April 28, 2023 12:31
@dany-on-demand dany-on-demand mentioned this pull request Apr 28, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant