Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print current working directory for "Command failed" #21

Closed
vorburger opened this issue Feb 18, 2024 · 2 comments · Fixed by #22
Closed

Print current working directory for "Command failed" #21

vorburger opened this issue Feb 18, 2024 · 2 comments · Fixed by #22
Labels
released

Comments

@vorburger
Copy link
Contributor

In an ideal world, it would be slightly more user friendly if when it fails and logs Command failed, it would include the current working directory.

This would have made debugging #20 a tiny bit more convenient. (Because it took me an instant to figure out that ./google-java-format_linux-x86-64 is in ~/.vscode/extensions/josevseb.google-java-format-for-vs-code-1.1.0/cache/b2...dc/`.)
JoseVSeb added a commit that referenced this issue Feb 18, 2024
@JoseVSeb
fix: run chmod +x for linux and mac native executables
e13368d 
fixes #20
fixes #21
@JoseVSeb
Copy link
Owner

i have added debug log when cwd is set.

@JoseVSeb JoseVSeb mentioned this issue Feb 18, 2024
Merged
JoseVSeb added a commit that referenced this issue Feb 18, 2024
@JoseVSeb
fix: run chmod +x for linux and mac native executables
680002a 
fixes #20
fixes #21
github-actions bot pushed a commit that referenced this issue Feb 18, 2024
@semantic-release-bot
chore(release): 1.1.1 [skip ci]
4c3f477 
## [1.1.1](v1.1.0...v1.1.1) (2024-02-18)

### Bug Fixes

* run chmod +x for linux and mac native executables ([680002a](680002a)), closes [#20](#20) [#21](#21)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: run chmod +x for linux and mac native executables JoseVSeb/google-java-format-for-vs-code
2 participants
@vorburger @JoseVSeb