Brightness does not work when triggered by notifications (With resolution) #76
Comments
AgP42
added a commit
to AgP42/MMM-Remote-Control
that referenced
this issue
Jul 23, 2018
Bug correction for Brightness control : Jopyth#76 New functionnalities : - add a Notification to others modules names "USER_PRESENCE" to true or false when MONITORON or MONITOROFF are requested - possibility to send this Notification "USER_PRESENCE" to true or false by other module request (for example, I use MMM-Navigation to send USER_PRESENCE to true to allow my module update on request) This notification "USER_PRESENCE" can also be send by the module MMM-PIR-Sensor.
AgP42
added a commit
to AgP42/MMM-Remote-Control
that referenced
this issue
Jul 23, 2018
- Add examples to use Remote-control with MMM-Navigate - Update to take into account the add of "USER_PRESENCE" notification to other modules (modification proposed on the 2 other files) - Update to add example to use Brightness modification (after the correction of the issue Jopyth#76 proposed into node_helper.js file)
|
Hey! This issue seems to be resolved, but if not feel free to reopen it. Cheers! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Goto: node_helper.js --> executeQuery function --> if (query.action === "BRIGHTNESS")...
The line "res.send({"status": "success"});" causes an error when calling the function with a notification because the variable res is null... Replace the line with "if (res) { res.send({"status": "success"}); }" to resolve the issue.
The text was updated successfully, but these errors were encountered: