Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove legacy import assertion unsupported by Node v22 #754

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

geigerzaehler
Copy link
Contributor

I wasn’t able to build the project using Node v22 because it used the legacy import assertion syntax. Support for this was removed from Node. To fix this, I’m reading package.json as to not rely on JSON module support which may be unavailable on older Node versions (?).

I’m also fixing the Github workflows so that they actually run against different Node versions and we can discover this in the future.

  • Quick Checklist
  • I have read the contributing guidelines
  • I have written new tests, as applicable (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • I have added a changeset, if applicable

Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: 0436e06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Collaborator

ah. apparently assert is becoming with: nodejs/node#51622

@benmccann benmccann merged commit edbd97a into JonasKruckenberg:main Nov 26, 2024
@geigerzaehler geigerzaehler deleted the node-v22 branch November 27, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants