Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text should be resizable #41

Open
JonasJurczok opened this issue Jul 25, 2018 · 11 comments
Open

Text should be resizable #41

JonasJurczok opened this issue Jul 25, 2018 · 11 comments

Comments

@JonasJurczok
Copy link
Owner

It should be possible to change the font size.

@hoylemd
Copy link
Contributor

hoylemd commented Jul 26, 2018

I think it would have something to do with the style parameter for the add method used to create ui elements. Takes a string or a LuaStyle object.

I've never worked in lua before, much less modding factorio, but I've been wanting to get into it. Maybe I'll try to tackle this as a first project.

@JonasJurczok
Copy link
Owner Author

JonasJurczok commented Jul 26, 2018 via email

This was referenced Jul 31, 2018
@hoylemd
Copy link
Contributor

hoylemd commented Aug 7, 2018

in #44, I just tweaked the styles a bit, but I'm thinking this could be implemented with a setting: Choose a UI style: normal (what it is now, or what is is in #44) or compact (smaller font size/padding etc)

@JonasJurczok
Copy link
Owner Author

JonasJurczok commented Aug 9, 2018 via email

@hoylemd
Copy link
Contributor

hoylemd commented Aug 10, 2018

That would work, but there's a couple different text sizes in use (So headings look like headings), and things like button height may need to adjust with it. So all of that would have to be computed from the user-selected font size, which really expands the potential error space. We could allow each value to be set individually, but that's a lot to ask of the average user.

But if we just had say, 3 UI sizes that we've chosen and tested, They just have to pick one and they're good to go.

@JonasJurczok
Copy link
Owner Author

JonasJurczok commented Aug 11, 2018 via email

@Tarrke
Copy link
Contributor

Tarrke commented Oct 24, 2018

The work to do here is just to get a way to choose which style to use, right ?

@hoylemd
Copy link
Contributor

hoylemd commented Oct 24, 2018

Yeah, you could have a setting to choose a size, and then have that setting determine which style to use when creating UI elements.

@JonasJurczok
Copy link
Owner Author

Yep. This was requested by a user. Maybe for really high/low resolutions the current default might be a problem.

@Tarrke
Copy link
Contributor

Tarrke commented Oct 26, 2018

Then @JonasJurczok can you add a pririty tag so we'll fix this quickly.

@JonasJurczok
Copy link
Owner Author

I don't know if this is actually urgent :) I view it more as a "nice to have"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants