You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#1024.
Prior to this commit, if the RPC connection were lost
while JoinmarketQt was running, the reactor would be
stopped, but the qt5reactor shutdown does not stop
the Qt Application. This commit fixes that by injecting
a custom reactor stop function wrapper into jmbase,
which triggers the close event of the Qt main window.
FixesJoinMarket-Org#1024.
Prior to this commit, if the RPC connection were lost
while JoinmarketQt was running, the reactor would be
stopped, but the qt5reactor shutdown does not stop
the Qt Application. This commit fixes that by injecting
a custom reactor stop function wrapper into jmbase,
which triggers the close event of the Qt main window.
Only error in console is printed, no feedback at all for GUI-only user.
Steps to reproduce:
I believe problem is
return None
instead ofsys.exit
here:joinmarket-clientserver/jmclient/jmclient/blockchaininterface.py
Lines 214 to 232 in 9a372fd
I'm not so familiar with Reactor, but could we raise some exception instead? @AdamISZ ?
The text was updated successfully, but these errors were encountered: