Merge pull request #1051 from JoinColony/maint/check-hooks-run-ci

Add new script for checking hooks run
JoinColony · Jun 20, 2022 · 869c7d8 · 869c7d8
2 parents a35ce13 + 176c5cb
commit 869c7d8
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 16 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -115,6 +115,9 @@ jobs:
       - run:
           name: "Linting Solidity"
           command: yarn run solhint
+      - run:
+          name: "Check git hooks run"
+          command: yarn run check:gitchanges
       - run:
           name: "Checking contract storage variables"
           command: yarn run check:storagevars

diff --git a/docs/_Interface_IColonyNetwork.md b/docs/_Interface_IColonyNetwork.md
@@ -937,21 +937,6 @@ Set a new Reputation root hash and starts a new mining cycle. Can only be called
 |stakers|address[]|Array of users who submitted or backed the hash, being accepted here as the new reputation root hash
 
 
-### `setReputationRootHash`
-
-This version of setReputationRootHash is deprecated and will be removed in a future release. It transparently calls the new version if it is called (essentially, removing the `reward` parameter.
-
-
-**Parameters**
-
-|Name|Type|Description|
-|---|---|---|
-|newHash|bytes32|The reputation root hash
-|newNLeaves|uint256|The updated leaves count value
-|stakers|address[]|Array of users who submitted or backed the hash, being accepted here as the new reputation root hash
-|reward|uint256|Amount of CLNY to be distributed as reward to miners (not used)
-
-
 ### `setTokenLocking`
 
 Sets the token locking address. This is only set once, and can't be changed afterwards.

diff --git a/lib/colonyToken b/lib/colonyToken
diff --git a/package.json b/package.json
@@ -9,6 +9,7 @@
     "solhint": "solhint ./contracts/**/*.sol",
     "build:docs": "scripts/docgen.js",
     "ping:osx": "osascript -e 'display notification \"Ping!\"'",
+    "check:gitchanges": "./scripts/no-git-changes.sh",
     "check:storagevars": "./scripts/check-storage.js",
     "check:recoverymods": "./scripts/check-recovery.js",
     "check:coverage": "yarn istanbul-combine -d coverage-merged -p detail -r html -r json coverage-*/coverage-final.json && istanbul check-coverage ./coverage-merged/coverage-final.json --statements 99 --branches 94 --functions 99 --lines 99",

diff --git a/scripts/no-git-changes.sh b/scripts/no-git-changes.sh
@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+set -e
+cd "$(dirname "$0")"
+
+if [[ `git status --porcelain` ]]; then
+  echo "GIT changes detected! Please always run all pre-commit hooks. `npm run build:docs` should help in most cases"
+
+  git status --verbose --verbose
+
+  exit 1
+fi